Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed BigQuery datasets that have colon in URI #855

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 19, 2021

The colon-based "project:dataset.table" format is no longer supported.

Fixes: #854

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
The colon-based "project:dataset.table" format is no longer supported.

Fixes: googleapis#854
@Ark-kun Ark-kun force-pushed the fix--Fixed-BigQuery-datasets-that-have-colon-in-URI branch from 3dedfeb to ee307ab Compare November 19, 2021 19:35
@Ark-kun Ark-kun removed their assignment Dec 7, 2021
@morgandu morgandu requested a review from ivanmkc January 5, 2022 20:15
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanmkc ivanmkc merged commit 153578f into googleapis:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when working with dataset when BigQuery source URI contains :
5 participants