feat: Added the PipelineJob.from_pipeline_func method #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Ark-kun
force-pushed
the
feat--Added-the-PipelineJob.submit_from_pipeline_func-method
branch
from
62b4c4c
to
50ff4fd
Compare
sasha-gitg
added
do not merge
sasha-gitg
requested changes
Jun 16, 2022
Ark-kun
force-pushed
the
feat--Added-the-PipelineJob.submit_from_pipeline_func-method
branch
from
1dff02e
to
901d857
Compare
…is called It's advised to not perform any complex operations (especially making external changes) as part of constructors of factory methods.
Ark-kun
force-pushed
the
feat--Added-the-PipelineJob.submit_from_pipeline_func-method
branch
from
0b0842b
to
5498f42
Compare
product-auto-label
bot
added
size: l
Ark-kun
changed the title
sasha-gitg
added
do not merge
…ith PipelineJob Unfortunately, the parameter_values parameter name itself was chosen inconsistently with the KFP SDK and ComponentSpec that both use the "arguments" naming.
Ark-kun
force-pushed
the
feat--Added-the-PipelineJob.submit_from_pipeline_func-method
branch
from
9aecbaf
to
85909e8
Compare
|
Hello. I think I've implemented and resolved all feedback. I've also added the new method to the integration tests and unit tests. (I'm not sure the integration tests are checked during the presubmit). |
sasha-gitg
approved these changes
Jul 7, 2022
sasha-gitg
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
abcdefgs0324
pushed a commit
to abcdefgs0324/python-aiplatform
that referenced
this pull request
Jul 20, 2022
The new factory method reduces the pipeline submission boilerplate to absolute minimum.
```python
aiplatform.PipelineJob.from_pipeline_func(training_pipeline).submit()
```
What it does:
1. Compiles pipeline
2. Provides sensible default values for the pipeline display name, job_id, context etc.
3. Generates GCS directory for the pipeline output artifacts if needed
4. Creates the GCS bucket for the artifacts if it does not exist. (And gives the Pipelines service account the required permissions)
Example usage:
```python
def training_pipeline(number_of_epochs: int = 10):
train_op(
number_of_epochs=number_of_epochs,
learning_rate="0.1",
)
job = aiplatform.PipelineJob.from_pipeline_func(training_pipeline)
job.submit()
```
---
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-aiplatform/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Fixes #<issue_number_goes_here> 🦕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new factory method reduces the pipeline submission boilerplate to absolute minimum.
What it does:
Example usage:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕