fix: Fix Timestamp, Duration and FieldMask marshaling in REST transport #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atulep
reviewed
Aug 5, 2022
| for more details. | ||
| """ | ||
|
|
||
| def to_python(self, value, *, absent: bool = None): |
There was a problem hiding this comment.
Is it expected to be a string ?
There was a problem hiding this comment.
what specifically? This just follows a similar convention of other Rules (they do exaclty the same thing as I have here).
atulep
reviewed
Aug 5, 2022
| def to_python(self, value, *, absent: bool = None): | ||
| return value | ||
|
|
||
| def to_proto(self, value): |
There was a problem hiding this comment.
What are possible types for value ?
There was a problem hiding this comment.
Is this protoplus proto or protobuf proto ?
atulep
approved these changes
Aug 5, 2022
atulep
reviewed
Aug 5, 2022
| for more details. | ||
| """ | ||
|
|
||
| def to_python(self, value, *, absent: bool = None): |
There was a problem hiding this comment.
This is not used - should be removed ?
There was a problem hiding this comment.
It is not used, but other rules still have it (i ti snot used in most places), so keeping it like this for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #333
BEGIN_COMMIT_OVERRIDE
fix: Fix Timestamp, Duration and FieldMask marshaling in REST transport
Release-As: 1.22.0
END_COMMIT_OVERRIDE