Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor coverage check #312

Merged
merged 2 commits into from
May 2, 2022
Merged

ci: refactor coverage check #312

merged 2 commits into from
May 2, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 29, 2022

This PR refactors the github action coverage check to test combined coverage across all checks. This is needed for #226 as there is a coverage gap when checks are evaluated individually rather than combined.

We use a similar check in googleapis python-* repos. See the templated file here.

@parthea parthea force-pushed the refactor-coverage branch from a5e4bad to a16477d Compare April 29, 2022 23:27
@parthea parthea changed the title for testing ci: refactor coverage check Apr 29, 2022
@parthea parthea marked this pull request as ready for review April 29, 2022 23:28
@parthea parthea requested review from a team as code owners April 29, 2022 23:28
@parthea parthea requested a review from atulep April 29, 2022 23:34
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea merged commit 079fc6a into main May 2, 2022
@parthea parthea deleted the refactor-coverage branch May 2, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants