Remove httplib2 imports from non-transport modules. #577
Conversation
| @@ -134,8 +133,8 @@ def _refresh(self, http_request): | |||
| self._retrieve_info(http_request) | |||
| self.access_token, self.token_expiry = _metadata.get_token( | |||
| http_request, service_account=self.service_account_email) | |||
| except httplib2.HttpLib2Error as e: | |||
| raise client.HttpAccessTokenRefreshError(str(e)) | |||
| except transport.transport_error() as err: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
towards-554-part3
branch
from
6581222
to
ee2411a
Compare
|
@jonparrott PTAL |
|
Also LMK if you want the two commits squashed into one before merging |
|
LGTM, and please squash and change the voice to active. |
dhermes
changed the title
Now all usage of httplib2 is concentrated in tests and in the oauth2client.transport module. This does not yet cover all behavior that implicitly relies on httplib2 in these modules, so there is still work to be done.
dhermes
force-pushed
the
towards-554-part3
branch
from
ee2411a
to
80fff4b
Compare
Now all usage of
httplib2is concentrated in tests and in theoauth2client.transportmodule. This does not yet cover all behavior that implicitly relies onhttplib2in these modules, so there is still work to be done.$ git grep import | grep httplib2 oauth2client/transport.py:import httplib2 samples/oauth2_for_devices.py:import httplib2 scripts/run_gce_system_tests.py:import httplib2 scripts/run_system_tests.py:import httplib2 tests/contrib/test_appengine.py:import httplib2 tests/contrib/test_flask_util.py:import httplib2 tests/contrib/test_gce.py:import httplib2 tests/contrib/test_metadata.py:import httplib2 tests/http_mock.py:import httplib2 tests/test_client.py:import httplib2 tests/test_service_account.py:import httplib2 tests/test_transport.py:import httplib2