Adding Python 3.5 capability #531

pferate · 2016-06-28T21:26:53Z

In Python 3.5, http.HTTPStatus was added, previously HTTP statuses were int.
Casting http.HTTPStatus as int to maintain backwards maintainability.

.travis.yml

@@ -1,6 +1,12 @@
 language: python
 python: 2.7
 sudo: false
+# A hack to install 3.5, until Travis-CI includes it


nathanielmanistaatgoogle · 2016-06-28T21:32:07Z

Does the body of your commit message wrap at seventy-two characters?

pferate · 2016-06-28T21:36:17Z

I was using 80 characters, since it looked like a few previous commits were using that. I'll switch it to 72.

I'll also add an issue, then reference it in the .travis.yml file.

tests/test_file.py

@@ -151,13 +151,13 @@ def test_token_refresh_store_expires_soon(self):
        access_token = '1/3w'
        token_response = {'access_token': access_token, 'expires_in': 3600}
        http = HttpMockSequence([
-            ({'status': str(http_client.UNAUTHORIZED)},
+            ({'status': str(int(http_client.UNAUTHORIZED))},


In Python 3.5, `http.HTTPStatus` was added, previously HTTP statuses were int. Casting `http.HTTPStatus` as int to maintain backwards maintainability.

pferate · 2016-06-28T22:10:51Z

Changes made, just waiting for Travis.

theacodes · 2016-06-28T22:14:09Z

Thanks, this looks good to merge once travis passes.

googlebot added the cla: yes label Jun 28, 2016

nathanielmanistaatgoogle reviewed Jun 28, 2016
View reviewed changes

nathanielmanistaatgoogle assigned theacodes Jun 28, 2016

pferate reviewed Jun 28, 2016
View reviewed changes

Adding Python 3.5 capability

8d88dbc

In Python 3.5, `http.HTTPStatus` was added, previously HTTP statuses were int. Casting `http.HTTPStatus` as int to maintain backwards maintainability.

pferate force-pushed the python35 branch from b1fa8f4 to 8d88dbc Compare June 28, 2016 22:08

theacodes merged commit 61c61a0 into googleapis:master Jun 29, 2016

pferate deleted the python35 branch June 30, 2016 19:59

theacodes mentioned this pull request Jul 28, 2016

Release 3.0.0 #575

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Python 3.5 capability #531

Adding Python 3.5 capability #531

pferate commented Jun 28, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nathanielmanistaatgoogle commented Jun 28, 2016

pferate commented Jun 28, 2016

This comment was marked as spam.

This comment was marked as spam.

pferate commented Jun 28, 2016

theacodes commented Jun 28, 2016

Adding Python 3.5 capability #531

Adding Python 3.5 capability #531

Conversation

pferate commented Jun 28, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nathanielmanistaatgoogle commented Jun 28, 2016

pferate commented Jun 28, 2016

This comment was marked as spam.

This comment was marked as spam.

pferate commented Jun 28, 2016

theacodes commented Jun 28, 2016