Add SQLAlchemy storage #527

miedzinski · 2016-06-23T20:47:13Z

Heavily inspired by oauth2client.contrib.django_orm.

oauth2client/contrib/sql_alchemy.py

+from sqlalchemy.types import PickleType
+
+
+__author__ = '[email protected] (Dominik Miedzinski)'


oauth2client/contrib/sql_alchemy.py

+"""OAuth 2.0 utilities for SQLAlchemy.
+Utilities for using OAuth 2.0 in conjunction with SQLAlchemy.
+Heavily inspired by equivalent Django module.
+"""


miedzinski · 2016-06-23T22:29:12Z

I have pushed new changes, as suggested. Note that this code was heavily inspired by existing Django module (including coding style and documentation quality).

theacodes · 2016-06-24T20:28:31Z

Note that this code was heavily inspired by existing Django module (including coding style and documentation quality).

I'm sorry you give you the impression of inconsistency here - but we are holding new changes to a higher standard than existing code. @waprin is working on re-writing the django modules to better fit our new standards and documentation quality.

oauth2client/contrib/sql_alchemy.py

+"""OAuth 2.0 utilities for SQLAlchemy.
+
+Utilities for using OAuth 2.0 in conjunction with SQLAlchemy.
+Heavily inspired by equivalent Django module.


oauth2client/contrib/sql_alchemy.py

+        """Write a Credentials to the SQLAlchemy datastore.
+
+        Args:
+            credentials: Credentials, the credentials to store.


theacodes · 2016-06-24T20:40:07Z

@miedzinski this is getting close, most of my nits are just around documentation and such. Thank you for this.

Once I'm satisfied, one of the other reviewers will do a final review. :)

tests/contrib/test_sqlalchemy.py

+        self.assertTrue(q.first() is None)
+
+
+if __name__ == '__main__':  # pragma: NO COVER


miedzinski · 2016-06-24T21:04:52Z

Done.

theacodes · 2016-06-27T17:40:39Z

I'm reasonably satisfied. @nathanielmanistaatgoogle do you want to take a look?

theacodes · 2016-06-28T20:03:08Z

@nathanielmanistaatgoogle seems to be very busy, @miedzinski please feel free to bug me tomorrow if he hasn't responded. Since this lives in contrib, I'd be okay with merging it.

oauth2client/contrib/sqlalchemy.py

+        Returns:
+            A :class:`oauth2client.Credentials` instance or `None`.
+        """
+        credential = None


nathanielmanistaatgoogle · 2016-06-28T21:22:42Z

Done with my first round of review.

miedzinski · 2016-06-28T21:59:34Z

There you go.

googlebot added the cla: yes label Jun 23, 2016

miedzinski mentioned this pull request Jun 23, 2016

SQLAlchemy Storage #345

Closed

miedzinski force-pushed the sqlalchemy-storage branch 2 times, most recently from f303d5b to 46481b0 Compare June 23, 2016 20:56

theacodes reviewed Jun 23, 2016
View reviewed changes

theacodes self-assigned this Jun 23, 2016

miedzinski force-pushed the sqlalchemy-storage branch from 46481b0 to 77ecb62 Compare June 23, 2016 21:13

theacodes reviewed Jun 23, 2016
View reviewed changes

oauth2client/contrib/sql_alchemy.py

"""OAuth 2.0 utilities for SQLAlchemy.

Utilities for using OAuth 2.0 in conjunction with SQLAlchemy.

Heavily inspired by equivalent Django module.

"""

This comment was marked as spam.

Sign in to view

miedzinski force-pushed the sqlalchemy-storage branch from 77ecb62 to f5b406e Compare June 23, 2016 22:23

miedzinski force-pushed the sqlalchemy-storage branch 4 times, most recently from e2884d7 to 78ba5a0 Compare June 23, 2016 23:38

theacodes reviewed Jun 24, 2016
View reviewed changes

oauth2client/contrib/sql_alchemy.py

"""OAuth 2.0 utilities for SQLAlchemy.

Utilities for using OAuth 2.0 in conjunction with SQLAlchemy.

Heavily inspired by equivalent Django module.

This comment was marked as spam.

Sign in to view

theacodes reviewed Jun 24, 2016
View reviewed changes

oauth2client/contrib/sql_alchemy.py

"""Write a Credentials to the SQLAlchemy datastore.

Args:

credentials: Credentials, the credentials to store.

This comment was marked as spam.

Sign in to view

theacodes reviewed Jun 24, 2016
View reviewed changes

miedzinski force-pushed the sqlalchemy-storage branch 2 times, most recently from bd88503 to dbd0fdb Compare June 24, 2016 21:03

theacodes assigned nathanielmanistaatgoogle Jun 27, 2016

miedzinski force-pushed the sqlalchemy-storage branch from dbd0fdb to c31ff3d Compare June 28, 2016 20:27

nathanielmanistaatgoogle reviewed Jun 28, 2016
View reviewed changes

oauth2client/contrib/sqlalchemy.py

Returns:

A :class:`oauth2client.Credentials` instance or `None`.

"""

credential = None

This comment was marked as spam.

Sign in to view

Add SQLAlchemy storage

5048d83

miedzinski force-pushed the sqlalchemy-storage branch from c31ff3d to 5048d83 Compare June 28, 2016 21:57

nathanielmanistaatgoogle merged commit 267bbc5 into googleapis:master Jun 29, 2016

theacodes mentioned this pull request Jul 28, 2016

Release 3.0.0 #575

Merged

google-admin unassigned nathanielmanistaatgoogle Sep 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SQLAlchemy storage #527

Add SQLAlchemy storage #527

miedzinski commented Jun 23, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

miedzinski commented Jun 23, 2016

theacodes commented Jun 24, 2016

This comment was marked as spam.

This comment was marked as spam.

theacodes commented Jun 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

miedzinski commented Jun 24, 2016

theacodes commented Jun 27, 2016

theacodes commented Jun 28, 2016

This comment was marked as spam.

nathanielmanistaatgoogle commented Jun 28, 2016

miedzinski commented Jun 28, 2016

		from sqlalchemy.types import PickleType


		__author__ = '[email protected] (Dominik Miedzinski)'

		self.assertTrue(q.first() is None)


		if __name__ == '__main__': # pragma: NO COVER

Add SQLAlchemy storage #527

Add SQLAlchemy storage #527

Conversation

miedzinski commented Jun 23, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

miedzinski commented Jun 23, 2016

theacodes commented Jun 24, 2016

This comment was marked as spam.

This comment was marked as spam.

theacodes commented Jun 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

miedzinski commented Jun 24, 2016

theacodes commented Jun 27, 2016

theacodes commented Jun 28, 2016

This comment was marked as spam.

nathanielmanistaatgoogle commented Jun 28, 2016

miedzinski commented Jun 28, 2016