This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
100% coverage for contrib.appengine #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhermes friendly ping on this one. |
| from oauth2client.contrib.appengine import FlowProperty | ||
| from oauth2client.contrib.appengine import ( | ||
| InvalidClientSecretsError as AppEngineInvalidClientSecretsError) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Finished review. Close to LGTM but no cigar. |
theacodes
force-pushed
the
test-coverage-appengine
branch
from
4f800de
to
3b1f6e5
Compare
|
Everything has been addressed, should be cigar now. |
| @@ -339,6 +417,27 @@ def setUp(self): | |||
| def tearDown(self): | |||
| self.testbed.deactivate() | |||
|
|
|||
| def test_bad_ctor(self): | |||
| with self.assertRaises(ValueError): | |||
| StorageByKeyName(CredentialsModel, None, None) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM Pretty please file an issue to encapsulate some of the issues / notes you're referring to in the module under test. |
theacodes
pushed a commit
that referenced
this pull request
Mar 17, 2016
100% coverage for contrib.appengine
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhermes this module and its existing tests are really quite messy, so I'm sorry if these tests seem a bit off.
Towards #212