This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Using mock App Engine module when building docs. #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanielmanistaatgoogle I manually closed and re-opened to get Travis to notice me. (This is the second PR I've sent in the last few days that didn't trigger the PR hook.) |
|
Looks good; merge when you like. |
|
Thanks. Will wait for Travis. |
dhermes
added a commit
that referenced
this pull request
Feb 23, 2016
Using mock App Engine module when building docs.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had some partially broken builds in both
latestandstable. See the sixth line in the build for the errors:The issue was a flaky snippet that downloaded the GAE SDK and I'm not sure why it worked sometimes and failed sometimes, but there is no reason to require that massive download.