-
Notifications
You must be signed in to change notification settings - Fork 430
Removing SignedJwtAssertionCredentials. #400
Removing SignedJwtAssertionCredentials. #400
Conversation
I can change Any idea why the tests haven't yet kicked off for this? |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@googlebot you're being silly and failing to recognize an authored-by-@dhermes-committed-by-@nathanielmanistaatgoogle commit as legitimate to merge. |
This completes the consolidation of the two service account credentials implementations. In the process, also adding test coverage for some untested code paths within the crypto helpers.
8adcb63
to
dcd20c9
Compare
|
Changed Any way to poke Travis to make it notice that a different commit has been pushed? I cancelled the test run of 81da3192423237b6. |
You've gotta figure out what the rate limit is. Need to check with whoever owns the org |
Still LGTM |
…vice-accounts-v4 Removed SignedJwtAssertionCredentials.
This is #399 with
tests/test__pycrypto_crypt.py
changed to useunittest2
.