Switching flask_util and django_util to use DictionaryStorage instead… #383
Conversation
| def locked_delete(self): | ||
| if _CREDENTIALS_KEY in self.session: | ||
| del self.session[_CREDENTIALS_KEY] | ||
| return DictionaryStorage(request.session, key=_CREDENTIALS_KEY) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. Coverage drop is fine; math and stuff. |
|
Please rewrite your commit message to conform to http://chris.beams.io/posts/git-commit/#seven-rules? Change content looks fine. |
theacodes
force-pushed
the
refactor-dict-storage
branch
from
5d9dfed
to
68c1e9a
Compare
|
@nathanielmanistaatgoogle was your primary issue the tense of the verb? I've fixed that. If you want more detail in the commit message I can add that as well. |
|
"Limit the subject line to 50 characters" is the one I usually notice, and that I noticed here. Notice how the title of the pull request overflows and is truncated with an ellipsis. |
theacodes
force-pushed
the
refactor-dict-storage
branch
from
68c1e9a
to
3460263
Compare
|
Hmm. I think that errs on the side of rules for the sake of rules, but I shortened it a bit (to 60 characters). |
|
Yeah, I don't like those rules either, but they're where the industry is going and I do favor consistency for metadata like commit messages. |
Agreed, but sometimes 50 characters isn't enough. :) Let me know if there's anything else I need to do here. Travis should turn green, the code itself hasn't changed since the PR was opened. |
|
This is fine. Will merge when tests repass. |
|
I don't know what's up with Travis. Merging. |
Switched flask_util and django_util to use DictionaryStorage.
|
Thanks! |
… of custom classes.