This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Updating setup.py and MANIFEST to include all subdirs. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change content looks good; are you inclined to include any more of the history or motivation in your commit message? If not, merge at your leisure. |
|
No I'm not inclined to do so. The motivation should be obvious from the content: we left out directories in our source tree (and we had a hard-coded packages list, which is overall a bad idea). |
dhermes
added a commit
that referenced
this pull request
Jan 8, 2016
Updating setup.py and MANIFEST to include all subdirs.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #364. Wanted to get it in before it falls off the radar.
H/T to @trcook for bringing the problem to our attention.