Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Moving devshell module to contrib. #376

Merged
merged 1 commit into from
Jan 9, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 5, 2016

See discussion in #370 for context.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 5, 2016

I should hold off on doing this until #372 is in.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 5, 2016

@nathanielmanistaatgoogle It looks like a brand new release of keyring no longer works in Python 2.6:
https://travis-ci.org/google/oauth2client/builds/100392153

Luckily keyring_storage is now in contrib, so we can make it optional (and leave the keyring tests out of the Python 2.6 tox environment).

More ammo for #298.

@dhermes dhermes force-pushed the move-devshell-to-contrib branch 2 times, most recently from f4c2406 to 40933c6 Compare January 8, 2016 22:56
@dhermes
Copy link
Contributor Author

dhermes commented Jan 8, 2016

@nathanielmanistaatgoogle I rebased after #372 got it.

@nathanielmanistaatgoogle
Copy link
Contributor

Change looks good; merge when tests repass.

See discussion in googleapis#370 for context.
dhermes added a commit that referenced this pull request Jan 9, 2016
@dhermes dhermes merged commit d783f1c into googleapis:master Jan 9, 2016
@dhermes dhermes deleted the move-devshell-to-contrib branch January 9, 2016 20:16
@dhermes dhermes mentioned this pull request Jan 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants