Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Unpinning tox version in install script. #362

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 14, 2015

Regressions from tox 2.2.0 were fixed in >=2.3.

Regressions from tox 2.2.0 were fixed in >=2.3.
@nathanielmanistaatgoogle
Copy link
Contributor

Completely unpinned dependencies are a project's way of saying "we would like to be broken sometime in the future at a time not of our choosing and with no advance notice". Why not just move the pin forward?

@dhermes
Copy link
Contributor Author

dhermes commented Dec 14, 2015

But using someone else's library is a way of saying "we are a part of an open-source eco-system" and by using the latest version is a way of telling our peers "we want to help you kick the tires of your library and are excited about new features you release"


In other words, I disagree. I think using the latest version on PyPI allows us to upgrade automatically when it does smoothly and quickly detect breakages when it does not.

@nathanielmanistaatgoogle
Copy link
Contributor

Okay.

nathanielmanistaatgoogle added a commit that referenced this pull request Dec 14, 2015
Unpinned tox version in install script.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 7559dcb into googleapis:master Dec 14, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Dec 14, 2015

Haha that was easy 😀 Thanks for the merge

@dhermes dhermes deleted the tox-unpin branch December 14, 2015 20:29
@dhermes dhermes mentioned this pull request Jan 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants