This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Improved unit-test line coverage and quality. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
force-pushed
the
remove-unittest-fail
branch
from
1a88de9
to
6bcf44d
Compare
| #!/usr/bin/python2.4 | ||
| # | ||
| # Copyright 2014 Google Inc. All rights reserved. | ||
| # Copyright 2015 Google Inc. All rights reserved. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
In particular - Upgraded some unit test modules to `unittest2`. - Got to 100% line coverage in `test_jwt`, `test_clientsecrets`, and `test_service_account` by using `self.assertRaises` instead of `self.fail()` - In some places used `self.assertRaises` as a context manager so the thrown exception can be inspected / compared against. This is done instead of manually catching the exception and holding on to it (`unittest2` backports this feature from `unittest` that was not available in Python 2.6) - Added license to `test_multistore_file` - Removed legacy `python2.4` hashbang from `test_jwt` and `test_service_account` - Added `unittest2` as a test dependency in `tox.ini` - Updated `test_clientsecrets.test_load_by_filename_missing_file` to use the `self.assertRaises` context manager (this was a problem in googleapis#349 and googleapis#350) - Updated `test_jwt` module docstring to reflect actual purpose
dhermes
force-pushed
the
remove-unittest-fail
branch
from
6bcf44d
to
f3a118a
Compare
|
@nathanielmanistaatgoogle Changes addressed. PTAL |
|
Looks good; merge when tests pass for the edited commit. |
|
Thanks! |
dhermes
added a commit
that referenced
this pull request
Dec 15, 2015
Improved unit-test line coverage and quality.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular
unittest2.test_jwt,test_clientsecrets,and
test_service_accountby usingself.assertRaisesinstead of
self.fail()self.assertRaisesas a context manager sothe thrown exception can be inspected / compared against. This
is done instead of manually catching the exception and
holding on to it (
unittest2backports this feature fromunittestthat was not available in Python 2.6)test_multistore_filepython2.4hashbang fromtest_jwtandtest_service_accountunittest2as a test dependency intox.initest_clientsecrets.test_load_by_filename_missing_fileto use the
self.assertRaisescontext manager (this wasa problem in More informative error when failing to open secrets file. #349 and More informative error when failing to open secrets file. #350)
test_jwtmodule docstring to reflect actual purpose