This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Avoid OAuth2Credentials id_token going out of sync after a token refresh. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. We need to resolve the test issue (an issue with our config / |
Closed
danring
force-pushed
the
update_id_token_on_refresh
branch
2 times, most recently
from
917b6a0
to
6882be0
Compare
danring
force-pushed
the
update_id_token_on_refresh
branch
from
6882be0
to
c53636e
Compare
|
@dhermes: looks good; merge when you're satisfied too. |
dhermes
added a commit
that referenced
this pull request
Dec 14, 2015
Avoid OAuth2Credentials id_token going out of sync after a token refresh.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After token refresh,
credential.id_tokenno longer matches_extract_id_token(credential.token_response['id_token']), as it does initially.access_token,token_expiryare updated, but notid_token.E.g., https://github.com/google/oauth2client/blob/master/oauth2client/client.py#L877 doesn't quite match https://github.com/google/oauth2client/blob/master/oauth2client/client.py#L2141