This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Using basic httplib call to check if on GCE. #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the potential issue of urllib detecting a proxy and changing the actual request underneath our code. The basic httplib library does not have any proxy detection, so this is not even possible there. Fixes googleapis#114.
This was referenced Aug 31, 2015
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Aug 31, 2015
Use basic httplib call to check if on GCE.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the potential issue of urllib detecting a proxy and changing the actual request underneath our code. The basic httplib library does not have any proxy detection, so this is not even possible there.
Fixes #114.
Also closes #120 (a somewhat old PR)