Adding travis and tox configuration to run the app engine tests #275

theacodes · 2015-08-17T18:34:49Z

Fixes #270.

theacodes · 2015-08-17T18:36:19Z

(Going to have to modify this a few times until travis works, will ping when it's green)

dhermes · 2015-08-17T19:34:53Z

We need to turn on caching so these installs don't take 50 seconds every time.

dhermes · 2015-08-17T19:35:23Z

I've seen this before on my machine when trying to fool it.

OSError: Config directory does not exist: /home/travis/.config/gcloud

theacodes · 2015-08-17T19:39:07Z

Was waiting to enable cache until I got it passing. The latest push should light up all green and should be ready to merge.

theacodes · 2015-08-17T19:43:53Z

Sigh. Not yet. Hold on.

dhermes · 2015-08-17T19:48:09Z

w00t green!

Regarding #212, we'll never light up as "100%" coverage unless the GAE tests run side-by-side with the rest. This PR is a fine stop-gap for now, but probably worth just doing them all at once once the cache is turned on (and we can just pull GAE stuff from the cache).

I know right know that the GAE imports get angry when django>1.5 is installed, but we could probably deal with that in the cover env.

theacodes · 2015-08-17T19:48:59Z

You can also trick coverage into compiling stats from multiple runs. We did this with the docs samples as well.

.travis.yml

+  # - TOX_ENV=pypy
+  # - TOX_ENV=docs
+  # - TOX_ENV=system-tests
+  # - TOX_ENV=system-tests3


theacodes · 2015-08-17T19:49:44Z

Can you reset travis' cache? It seems I cached a bad install of the SDK. Once that's reset, we should have green tests.

.travis.yml

+  # - TOX_ENV=system-tests3
+  - TOX_ENV=gae
+  global:
+  - GAE_PYTHONPATH=$HOME/google_appengine


theacodes · 2015-08-17T19:58:24Z

Still trying to get travis' cache to play along.

tox.ini

@@ -51,6 +51,15 @@ basepython = python2.6
 deps = {[testenv]basedeps}
       django>=1.5,<1.6

+[testenv:gae]


.travis.yml

+  # - TOX_ENV=system-tests3
+  - TOX_ENV=gae
+  global:
+  - GAE_PYTHONPATH=$HOME/.cache/google_appengine


dhermes · 2015-08-17T20:03:25Z

RE:

You can also trick coverage into compiling stats from multiple runs. We did this with the docs samples as well.

So cool! Does this work when using matrix env in Travis?

theacodes · 2015-08-17T20:04:12Z

So cool! Does this work when using matrix env in Travis?

I don't think so. Maybe?
GAE causes all kinds of testing problems.

dhermes · 2015-08-17T20:04:16Z

I can clear it for you in the settings if need be (you might not have privileges, I might not either though): http://docs.travis-ci.com/user/caching/#Clearing-Caches

theacodes · 2015-08-17T20:04:33Z

I don't have rights to clear the cache.

dhermes · 2015-08-17T20:05:20Z

Do you want me to try to clear it?

theacodes · 2015-08-17T20:05:21Z

Okay - confirmed the settings are correct with a new cache directory (cache2). If someone can kill the broken cache, then this should light up all green. :)

theacodes · 2015-08-17T20:05:32Z

Do you want me to try to clear it?

Yes, please.

dhermes · 2015-08-17T20:06:06Z

@jonparrott Just deleted the cache

theacodes · 2015-08-17T20:06:27Z

Presses big red button

scripts/install.sh

+    mkdir -p `dirname ${GAE_PYTHONPATH}`
+    cd `dirname ${GAE_PYTHONPATH}`
+    wget https://storage.googleapis.com/appengine-sdks/featured/google_appengine_1.9.25.zip
+    unzip -q google_appengine_1.9.25.zip


theacodes · 2015-08-17T20:09:53Z

system-tests3 failed for some weird unrelated reason. This should be good to go, but I can trigger another build to be sure.

dhermes · 2015-08-17T20:11:07Z

No need to re-trigger, but there are at two comments un-addressed (about hard-coding the version and making the ~/.config/gcloud dir)

scripts/install.sh

@@ -25,3 +25,9 @@ if [[ "${TOX_ENV}" == "pypy" ]]; then
    pyenv install pypy-2.6.0
    pyenv global pypy-2.6.0
 fi
+
+if [[ "${TOX_ENV}" == "gae" && ! -d ${GAE_PYTHONPATH} ]]; then
+    python scripts/fetch_gae_sdk.py `dirname ${GAE_PYTHONPATH}`


theacodes · 2015-08-17T20:24:27Z

travis has forced my hand on the one test that depends on ~/.config/gcloud, I just pushed a change that should fix that.

theacodes · 2015-08-17T20:26:56Z

Finally, green.

tests/test_appengine.py

@@ -240,8 +242,10 @@ def test_get_access_token(self):
    self.assertEqual(None, token.expires_in)

  def test_save_to_well_known_file(self):
+    os.environ[_CLOUDSDK_CONFIG_ENV_VAR] = tempfile.mkdtemp()


dhermes · 2015-08-17T20:36:40Z

LGTM

Adding travis and tox configuration to run the app engine tests

googlebot added the cla: yes label Aug 17, 2015

theacodes force-pushed the master branch from aa9e21c to c2f8343 Compare August 17, 2015 18:35

theacodes force-pushed the master branch 3 times, most recently from bfb3b9d to 305e5a6 Compare August 17, 2015 19:31

theacodes force-pushed the master branch 2 times, most recently from 86d0826 to 5f9ffb1 Compare August 17, 2015 19:38

theacodes force-pushed the master branch 2 times, most recently from 7ac4d00 to 2c2639d Compare August 17, 2015 19:45

theacodes force-pushed the master branch from 2c2639d to 620d5ca Compare August 17, 2015 19:48