Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Should we use a more generic transport for _detect_gce_environment() #599

Closed
dhermes opened this issue Aug 10, 2016 · 1 comment
Closed
Milestone

Comments

@dhermes
Copy link
Contributor

dhermes commented Aug 10, 2016

The current source uses the core httplib / http.client machinery to get the info.

  1. The original reason we used the low-level library is because the timeout in httplib2 was taking too long. This may no longer be an issue, i.e. if the GCE check is the last one
  2. It should probably use oauth2client.contrib._metadata utils

I'm filing this because after #586 all requests (except for this one) are "guaranteed" to pass through the transport.request method

@theacodes
Copy link
Contributor

Yes. Let's.

@theacodes theacodes added bug and removed question labels Aug 10, 2016
@theacodes theacodes added this to the 4.0.0 milestone Aug 10, 2016
dhermes added a commit to dhermes/oauth2client that referenced this issue Aug 11, 2016
dhermes added a commit to dhermes/oauth2client that referenced this issue Aug 11, 2016
dhermes added a commit to dhermes/oauth2client that referenced this issue Aug 15, 2016
dhermes added a commit to dhermes/oauth2client that referenced this issue Aug 15, 2016
dhermes added a commit to dhermes/oauth2client that referenced this issue Aug 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants