Coveralls report not being used

[dhermes]

As a result coverage has dropped below 100% and sadness for me since #212 was so hard.

See an example fail when trying to upload the coverage report to coveralls.io:

  File "/home/travis/build/google/oauth2client/.tox/coveralls/lib/python2.7/site-packages/nosegae.py", line 91, in configure
    import dev_appserver
ImportError: No module named dev_appserver

[dhermes]

@jonparrott Do you know if /home/travis/.cache/google_appengine needs to be populated in each of the environments? i.e. why does gae work just fine but py27 fails on the coverage report.

Could we "fix" this with a simple cheat of moving the coverage report into gae from py27?

[dhermes]

OK as can be seen in #560 this does fix the import issue and brings back the coveralls report.

As seen in the report https://coveralls.io/builds/7092809 we have 97.06% coverage in oauth2client.contrib.sqlalchemy and 99.37% inoauth2client.contrib.appengine`.

It looks like there's a branch mass in contrib.appengine in the 807-809, 806->807 range and some other missed in contrib.sqlalchemy around 150, 144->150, 146->148, 162->165.

[theacodes]

Well the good news is we're not significantly below 100%.

[dhermes]

Indeed. Any idea who the owners should be to get back to 100%?

[theacodes]

I can probably handle it sometime in the next month.

On Wed, Jul 20, 2016, 8:01 PM Danny Hermes [email protected] wrote:

Indeed. Any idea who the owners should be to get back to 100%?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#558 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUcxq5WhhiYTF72GFYnPgTvMPKYRizks5qXuEMgaJpZM4JRKhl
.

[pferate]

One of those was me in #533. I just wrote a test to get the appengine part covered. Haven't looked at the sqlalchemy part yet.

I'll look at that after I finish working on my other PR.