Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Get flask_util to 100% code coverage #277

Closed
dhermes opened this issue Aug 23, 2015 · 3 comments
Closed

Get flask_util to 100% code coverage #277

dhermes opened this issue Aug 23, 2015 · 3 comments
Labels

Comments

@dhermes
Copy link
Contributor

dhermes commented Aug 23, 2015

See #212

@theacodes
Copy link
Contributor

I think the only thing missing from coverage is the import check at the topic. Unsure on how to test that - any recommendations?

@dhermes
Copy link
Contributor Author

dhermes commented Aug 24, 2015

Looking at the output from #212:

oauth2client.flask_util          170      9     42      7    92%   180-181, 383-384, 387, 394-397

The lines 180-181 are

except ImportError:
    raise ImportError('The flask utilities require flask 0.9 or newer.')

which you could mark with pragma: NO COVER.

The rest are valid code paths that need to be traversed.

@theacodes
Copy link
Contributor

Gotcha. Will do.

On Mon, Aug 24, 2015 at 9:22 AM Danny Hermes [email protected]
wrote:

Looking at the output from #212
#212:

oauth2client.flask_util 170 9 42 7 92% 180-181, 383-384, 387, 394-397

The lines 180-181 are

except ImportError:
raise ImportError('The flask utilities require flask 0.9 or newer.')

which you could mark
https://github.com/google/oauth2client/blob/b821f6ee88f472f8523525b049c42583d9182faa/.coveragerc#L5
with pragma: NO COVER.

The rest are valid code paths that need to be traversed.


Reply to this email directly or view it on GitHub
#277 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants