Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech #4

beccasaurus · 2018-03-23T19:26:19Z

Add code samples for listing voices and synthesizing speech audio files (from plain text or SSML)

Canonical samples (Python PR):

tts_quickstart
tts_list_voices
tts_synthesize_text
tts_synthesize_ssml
tts_synthesize_text_file
tts_synthesize_ssml_file
Generate Readme
Tests and linter pass
Code coverage does not decrease (if any source code was changed)

… into samples

beccasaurus · 2018-03-23T21:31:18Z

I can't add @nnegrey or @dizcology as reviewers on this project 😕

@lukesneeringer/@alexander-fenster I need to request reviews from ML API DPEs on some Node.js PRs to approve the ML requirements side of things. Can I get them added to the nodejs repos? They won't ever be the solo reviewer, but they should be able to block merges and request changes. Guessing this requires adding to Node team?

samples/listVoices.js

+      console.log('Voices:');
+      voices.forEach(voice => {
+        console.log(`Name: ${voice.name}`);
+        console.log(`  SSML Gender: ${voice.ssmlGender}`);


alexander-fenster · 2018-03-23T22:35:32Z

@remi I can add them to this particular repo as contributors but not to the team - you might need to ask @ofrobots to do that.

Unrelated note: the lint task seems to be failing because it's not properly configured in .circleci/config.yml - you can grab the lint steps from any project with existing samples, or let me know if you want me to do it.

ofrobots · 2018-03-23T22:55:45Z

What precisely is being asked for re: addition:

Add @nnegrey and @dizcology so that they can review code? Anyone can leave review comments, so just mentioning them (as has already been done) is adequate.
Add said folks as collaborators so that they can officially sign-off on code reviews. @alexander-fenster can do that. Note that this will also grant them write permissions to the code; so the expectation would be that they are 'code owners' in this repo if we go this route.
Add said folks to a new github 'team'. This is the same as the previous bullet, except that it additionally gives you a single team-name that you can use. I seem to have adequate permission to be able to do this. We do get slightly more control as a team can be given either Read or Write permissions.

beccasaurus · 2018-03-24T00:11:34Z

Just having @nnegrey is enough for now, thanks!

… into samples

…source files

… into samples

codecov-io · 2018-03-24T00:32:49Z

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b01b2a...cb32701. Read the comment docs.

README.md

+    const audioContent = results[0].audioContent;
+
+    // Write the audio content to a local file
+    fs.writeFileSync('output.mp3', audioContent, 'binary');


samples/system-test/quickstart.test.js

+});
+
+test(`should synthesize speech to local mp3 file`, async t => {
+  t.false(fs.existsSync(outputFile));


beccasaurus · 2018-03-24T01:13:17Z

Blocked on #5

beccasaurus · 2018-03-24T01:26:26Z

@alexander-fenster I updated the MP3 file which each snippet writes to do so asynchronously (as you pointed out, while in a .then() we may as well .then(async r =>) but now I get complaints from the linter about this:

> @google-cloud/[email protected] lint /home/node/project
> repo-tools lint --cmd eslint -- src/ samples/ system-test/ test/ smoke-test/

lint: Linting files in: /home/node/project
lint: Running: eslint src/ samples/ system-test/ test/ smoke-test/

/home/node/project/samples/quickstart.js
  42:9  error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
  47:5  error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features

/home/node/project/samples/synthesize.js
   39:11  error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
   42:7   error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
   72:11  error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
   75:7   error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
  105:11  error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
  108:7   error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
  138:11  error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features
  141:7   error  Async functions are not supported yet on Node >=4.0.0  node/no-unsupported-features

✖ 10 problems (10 errors, 0 warnings)

lint: Oh no! Linting failed after 1.52s.

https://circleci.com/gh/googleapis/nodejs-text-to-speech/167?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

beccasaurus · 2018-03-26T19:22:00Z

@alexander-fenster @lukesneeringer @jonparrott How do the system-tests for for nodejs-* libraries?

These samples are good to merge, but I don't see ./nodejs-text-to-speech/system-tests/ whereas I see it in the other nodejs libraries?

IIUC you can configure the generation of these in the gapic.yaml?

.cloud-repo-tools.json

@@ -9,5 +9,21 @@
  "requiresKeyFile": true,
  "requiresProjectId": true,
  "client_reference_url": "https://cloud.google.com/nodejs/docs/reference/text-to-speech/latest/",
-  "release_quality": "alpha"
+  "release_quality": "alpha",


… into samples

README.md

@@ -43,7 +46,7 @@ Google APIs Client Libraries, in [Client Libraries Explained][explained].

    [Enable billing][billing]

-1.  Enable the Google Cloud Text-To-Speech API.
+1.  Enable the Google Cloud Text-to-Speech API API.


JSzaszvari · 2018-04-27T01:39:50Z

Thanks, This PR is amazingly useful. Helped me get off the ground.

beccasaurus · 2018-04-27T01:42:54Z

Thanks @JSzaszvari! This fell off of my radar, lemme see if I can get it merged

alexander-fenster · 2018-04-27T04:44:42Z

@crwilcox This change fails on master because we need to setup samples tests properly. Let's meet together and make the tests run (need to setup an encryption key).

Rebecca Taylor added 2 commits March 22, 2018 23:06

Sample: List available voices [tts_list_voices]

880cb25

Samples: Synthesize Speech (text, ssml, string, local file)

fbe2481

alexander-fenster added the do not merge label Mar 23, 2018

alexander-fenster and others added 8 commits March 23, 2018 12:34

Merge branch 'master' into samples

34dce9b

Samples: extract speech synthesis samples

562a440

s/var/const/g

5131b3a

Samples: add quickstart

4b01e93

Samples: change printed output after writing mp3 files

d33b076

Add samples to .cloud-repo-tools

d3ac34d

Merge branch 'samples' of github.com:googleapis/nodejs-text-to-speech…

e9615a1

… into samples

Samples: update with prettier

6eb1ea6

beccasaurus requested a review from alexander-fenster March 23, 2018 21:27

Rebecca Taylor added 2 commits March 23, 2018 14:36

$ npm run generate-scaffolding

0db5e36

Samples: fix lint error for unused closure arg var

964afec

nnegrey reviewed Mar 23, 2018

View reviewed changes

samples/listVoices.js Outdated

console.log('Voices:');

voices.forEach(voice => {

console.log(`Name: ${voice.name}`);

console.log(` SSML Gender: ${voice.ssmlGender}`);

This comment was marked as spam.

Sign in to view

Samples: use simple SSML examples, eg. <speak>Hello there.</speak>

d43ad19

Update links and whatnot

b2ab081

alexander-fenster and others added 6 commits March 23, 2018 17:22

making lint and samples work in circle

f47d62e

Regen README

6edf91d

samples package.json

11fa592

Merge branch 'samples' of github.com:googleapis/nodejs-text-to-speech…

c8c52e2

… into samples

Update synthesize.js sample CLI help to show existing TXT and SSML re…

e6fe3f6

…source files

Merge branch 'samples' of github.com:googleapis/nodejs-text-to-speech…

9e5daf1

… into samples

alexander-fenster reviewed Mar 24, 2018

View reviewed changes

samples/system-test/quickstart.test.js

});

test(`should synthesize speech to local mp3 file`, async t => {

t.false(fs.existsSync(outputFile));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

beccasaurus changed the title ~~[DO NOT MERGE] Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech~~ [DO NOT MERGE] Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech [BLOCKED pending Library System Tests] Mar 24, 2018

Rebecca Taylor added 2 commits March 23, 2018 18:17

Samples: update writing bytes to mp3 files to be async

e235bf3

Update quickstart to write mp3 file asynchronously

ed07e6b

Rebecca Taylor added 3 commits March 23, 2018 19:06

Samples: Use async I/O when writing MP3 files

fced808

Samples - updated with prettier

fea561e

Samples: update Quickstart to use async file I/O when writing MP3 file

811f1ca

alexander-fenster approved these changes Mar 24, 2018

View reviewed changes

beccasaurus changed the title ~~[DO NOT MERGE] Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech [BLOCKED pending Library System Tests]~~ Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech [BLOCKED pending Library System Tests] Mar 26, 2018

Merge branch 'master' into samples

01df278

jmdobry suggested changes Mar 28, 2018

View reviewed changes

jmdobry mentioned this pull request Mar 28, 2018

API page is not found #8

Closed

Rebecca Taylor added 3 commits March 28, 2018 13:17

Upgrade repo-tools to 2.2.6 and run scaffolding

469b101

Merge branch 'samples' of github.com:googleapis/nodejs-text-to-speech…

3cc9711

… into samples

Merge branch 'master' into samples

754f4ec

beccasaurus removed the do not merge label Mar 28, 2018

beccasaurus changed the title ~~Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech [BLOCKED pending Library System Tests]~~ Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech Mar 28, 2018

jmdobry approved these changes Mar 28, 2018

View reviewed changes

mattgi mentioned this pull request Apr 4, 2018

readme points users to install a different package #11

Closed

bpartridge83 reviewed Apr 8, 2018

View reviewed changes

README.md Outdated

@@ -43,7 +46,7 @@ Google APIs Client Libraries, in [Client Libraries Explained][explained].

[Enable billing][billing]

1. Enable the Google Cloud Text-To-Speech API.

1. Enable the Google Cloud Text-to-Speech API API.

This comment was marked as spam.

Sign in to view

Rebecca Taylor and others added 2 commits April 26, 2018 19:18

Fix typo in README

e383927

make lint pass

cb32701

beccasaurus merged commit 3a3fc71 into master Apr 27, 2018

beccasaurus deleted the samples branch April 27, 2018 03:31

JustinBeckwith mentioned this pull request Jun 1, 2018

Cannot find module 'text-to-speech' #9

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech #4

Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech #4

beccasaurus commented Mar 23, 2018 •

edited

Loading

beccasaurus commented Mar 23, 2018

This comment was marked as spam.

alexander-fenster commented Mar 23, 2018

ofrobots commented Mar 23, 2018

beccasaurus commented Mar 24, 2018

codecov-io commented Mar 24, 2018 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

beccasaurus commented Mar 24, 2018

beccasaurus commented Mar 24, 2018

beccasaurus commented Mar 26, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

JSzaszvari commented Apr 27, 2018

beccasaurus commented Apr 27, 2018

alexander-fenster commented Apr 27, 2018

Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech #4

Text-to-Speech Code Samples for Listing Voices and Synthesizing Speech #4

Conversation

beccasaurus commented Mar 23, 2018 • edited Loading

beccasaurus commented Mar 23, 2018

This comment was marked as spam.

alexander-fenster commented Mar 23, 2018

ofrobots commented Mar 23, 2018

beccasaurus commented Mar 24, 2018

codecov-io commented Mar 24, 2018 • edited Loading

Codecov Report

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

beccasaurus commented Mar 24, 2018

beccasaurus commented Mar 24, 2018

beccasaurus commented Mar 26, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

JSzaszvari commented Apr 27, 2018

beccasaurus commented Apr 27, 2018

alexander-fenster commented Apr 27, 2018

beccasaurus commented Mar 23, 2018 •

edited

Loading

codecov-io commented Mar 24, 2018 •

edited

Loading