Upgrade nodejs-common #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
added
do not merge
googlebot
added
the
cla: yes
|
|
stephenplusplus
added
the
status: blocked
stephenplusplus
removed
the
status: blocked
stephenplusplus
force-pushed
the
spp--common-upgrade
branch
from
a76a0d4 to
619676b
Compare
stephenplusplus
removed
the
do not merge
callmehiphop
approved these changes
Jan 28, 2019
| @@ -522,6 +522,13 @@ class Bucket extends ServiceObject { | |||
| // Allow for "gs://"-style input, and strip any trailing slashes. | |||
| name = name.replace(/^gs:\/\//, '').replace(/\/+$/, ''); | |||
|
|
|||
| const requestQueryObject: {userProject?: string} = {}; | |||
There was a problem hiding this comment.
Should we just declare an external interface for this? Not sure if it will ever be useful for the user or not.
There was a problem hiding this comment.
While serviceObject(config.methods[method].reqOpts follows the request library's signature, I would still consider it private behavior. I wouldn't document it, since we might come up with something different in the future, and I'm not sure the user would understand exactly what it does / what side effects it has.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked On
feat: allow options to ServiceObject methods nodejs-common#349Release gcs-resumable-upload v0.14.0 gcs-resumable-upload#167fix: return GaxiosError directly gcs-resumable-upload#171fix: favor user options over defaults nodejs-common#353fix: clone default request configuration object nodejs-common#356I took the code from @JustinBeckwith out of #556.