Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket lock samples and tests #418

Merged
merged 6 commits into from
Oct 3, 2018
Merged

Bucket lock samples and tests #418

merged 6 commits into from
Oct 3, 2018

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Sep 29, 2018 •
edited
Loading

Bucket Lock Samples

In collaboration with @billyjacobson.

  • Code coverage does not decrease (@stephenplusplus -- what are the expectations for code coverage w.r.t to samples?)
  • Appropriate docs were updated (@stephenplusplus -- not sure what needs to be done here). These samples will be part of documentation for GCS but not sure if I need to do additional work.
  • Tests
  • linter pass
  • Define a retention policy
  • Remove a retention policy if not locked
  • Lock a retention policy
  • Set temporary hold
  • Release temporary hold
  • Set event-based hold
  • Release event-based hold
  • Set default event-based hold
  • Release default event-based hold
  • View default event-based hold
  • View bucket retention policy metadata
  • View metadata for object
  • Updated CLI
  • Add CLI examples
  • Updated README.md

@ghost ghost assigned frankyn Sep 29, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2018
stephenplusplus
stephenplusplus reviewed Sep 29, 2018
View reviewed changes
samples/bucketLock.js Outdated
if (metadata.hasOwnProperty('retentionPolicy')) {
const retentionPolicy = metadata.retentionPolicy;
console.log('Retention policy:');
console.log(`\tperiod: ${retentionPolicy.retentionPeriod}`);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

samples/bucketLock.js Outdated
})
.then(results => {
const metadata = results[0];
if (

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Oct 1, 2018 •
edited
Loading

  • Appropriate docs were updated (@stephenplusplus -- not sure what needs to be done here). This samples will be part of documentation for GCS but not sure if I need to do additional work.

/cc @jmdobry about @frankyn's question above.

RE code coverage, samples aren't included in the coverage report, and aren't required AFAIK, so no worries.

frankyn
frankyn commented Oct 1, 2018
View reviewed changes
samples/package.json Outdated
@@ -22,7 +22,7 @@
},
"dependencies": {
"@google-cloud/pubsub": "*",
"@google-cloud/storage": "^2.0.3",
"@google-cloud/storage": "+git",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 3, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 3, 2018
@frankyn
Copy link
Member Author

frankyn commented Oct 3, 2018

Synced with @JustinBeckwith about the open question @stephenplusplus and it's a no-op.

@frankyn frankyn merged commit 0b712ec into googleapis:revert-373-revert-320-spp--bucket-lock Oct 3, 2018
@frankyn frankyn deleted the bucketlock branch October 3, 2018 20:51
frankyn added a commit that referenced this pull request Oct 3, 2018
@frankyn
Bucket lock samples and tests (#418)
6f85575 
* Bucket lock samples and tests

* Address feedback

* Address lint issues

* Revert +git from storage dep version

* Fix lint issue and merge issue
@frankyn frankyn restored the bucketlock branch October 3, 2018 21:56
stephenplusplus pushed a commit that referenced this pull request Oct 3, 2018
@frankyn
Bucket lock samples and tests (#418)
161dd95 
* Bucket lock samples and tests

* Address feedback

* Address lint issues

* Revert +git from storage dep version

* Fix lint issue and merge issue
JustinBeckwith pushed a commit that referenced this pull request Oct 9, 2018
@frankyn @JustinBeckwith
Bucket lock samples and tests (#418)
0bc899a 
* Bucket lock samples and tests

* Address feedback

* Address lint issues

* Revert +git from storage dep version

* Fix lint issue and merge issue
@frankyn frankyn deleted the bucketlock branch February 20, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees

@frankyn frankyn

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frankyn @stephenplusplus @googlebot @JustinBeckwith @billyjacobson