Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): updated gcs-resumable-upload dependency #1459

Merged

Conversation

shaffeeullah
Copy link
Contributor

Fixes #1373 🦕

Authentication is bypassed when using an emulator in this release of gcs-resumable-upload. This PR updates the dependency so storage has this fix.

@shaffeeullah shaffeeullah requested a review from a team May 4, 2021 15:44
@shaffeeullah shaffeeullah requested a review from a team as a code owner May 4, 2021 15:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #1459 (9c09d14) into master (62832a9) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
+ Coverage   98.98%   99.10%   +0.11%     
==========================================
  Files          14       14              
  Lines       11581    12190     +609     
  Branches      598      532      -66     
==========================================
+ Hits        11464    12081     +617     
+ Misses        117      109       -8     
Impacted Files Coverage Δ
src/bucket.ts 99.77% <100.00%> (+0.23%) ⬆️
src/file.ts 99.94% <100.00%> (+<0.01%) ⬆️
src/hmacKey.ts 100.00% <100.00%> (ø)
src/notification.ts 100.00% <100.00%> (ø)
src/signer.ts 99.77% <100.00%> (+0.01%) ⬆️
src/storage.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee8201...9c09d14. Read the comment docs.

@shaffeeullah shaffeeullah merged commit afaccc7 into master May 4, 2021
@shaffeeullah shaffeeullah deleted the shaffeeullah/updateGcsResumableUploadDependency branch May 4, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Could not load the default credentials" when using custom apiEndpoint.
2 participants