chore: update proto comments and fix tests #316

yoshi-automation · 2019-03-12T11:25:17Z

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:30babbfce7f05a62b1892c63c575aa2c8c502eb4bcc8f3bb90ec83e955d5d319
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/speech/artman_speech_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/speech-v1.
synthtool > Replaced '(mockBidiStreamingGrpcMethod\\()request' in test/gapic-v1.js.
synthtool > Replaced 'stream\\.write\\(request\\)' in test/gapic-v1.js.
synthtool > Replaced '// Mock request\n\\s*const request = {};' in test/gapic-v1.js.
synthtool > Running generator for google/cloud/speech/artman_speech_v1p1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/speech-v1p1beta1.
synthtool > Replaced '(mockBidiStreamingGrpcMethod\\()request' in test/gapic-v1p1beta1.js.
synthtool > Replaced 'stream\\.write\\(request\\)' in test/gapic-v1p1beta1.js.
synthtool > Replaced '// Mock request\n\\s*const request = {};' in test/gapic-v1p1beta1.js.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test-grpcjs.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node6/common.cfg
.kokoro/continuous/node6/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test-grpcjs.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node6/common.cfg
.kokoro/presubmit/node6/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
codecov.yaml
renovate.json

> [email protected] install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using needle for node-pre-gyp https download 
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote

> [email protected] postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1123 packages from 1321 contributors and audited 6925 packages in 25.143s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details

> @google-cloud/[email protected] fix /tmpfs/src/git/autosynth/working_repo
> eslint --fix '**/*.js'


/tmpfs/src/git/autosynth/working_repo/samples/betaFeatures.js
   31:26  error  "@google-cloud/speech" is not found  node/no-missing-require
   80:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  131:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  172:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  211:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  248:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  288:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  334:26  error  "@google-cloud/speech" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/MicrophoneStream.js
  46:26  error  "node-record-lpcm16" is not found    node/no-missing-require
  49:26  error  "@google-cloud/speech" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/quickstart.js
  21:26  error  "@google-cloud/speech" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/recognize.js
   35:26  error  "@google-cloud/speech" is not found  node/no-missing-require
   79:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  124:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  182:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  231:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  279:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  344:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  383:26  error  "node-record-lpcm16" is not found    node/no-missing-require
  386:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  449:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  501:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  551:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  600:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  643:26  error  "@google-cloud/speech" is not found  node/no-missing-require
  684:26  error  "@google-cloud/speech" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/recognize.v1p1beta1.js
  38:26  error  "@google-cloud/speech" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/betaFeatures.test.js
  19:26  error  "chai" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/MicrophoneStream.test.js
  19:26  error  "chai" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/recognize.test.js
  19:27  error  "@google-cloud/storage" is not found  node/no-missing-require
  20:26  error  "chai" is not found                   node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/system-test/recognize.v1p1beta1.test.js
  19:27  error  "@google-cloud/storage" is not found  node/no-missing-require
  20:26  error  "chai" is not found                   node/no-missing-require

✖ 33 problems (33 errors, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/[email protected] fix: `eslint --fix '**/*.js'`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/[email protected] fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2019-03-12T11_25_13_592Z-debug.log
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

…ary generator.

JustinBeckwith · 2019-03-12T18:11:18Z

@callmehiphop they're probably unrelated, but could you dig into the failure here?

codecov · 2019-03-13T17:18:12Z

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #316   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          35     35           
=====================================
  Hits           35     35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64137ea...4460f22. Read the comment docs.

googlebot · 2019-03-13T17:18:12Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

callmehiphop · 2019-03-13T18:16:51Z

@JustinBeckwith I'm not sure if it should matter or not, but I noticed in our other synchronous recognize tests we're using a smaller file than what was being used in the v1p1beta1 spec. I swapped the files and it appears to have made CI happy. 🤷‍♂️

While I was in there, I decided to clean the spec file up a bit - we were creating and deleting a bucket that never got used. But yeah, PTAL!

googlebot · 2019-03-13T20:49:28Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[CHANGE ME] Re-generated to pick up changes in the API or client libr…

6f49848

…ary generator.

yoshi-automation force-pushed the autosynth branch from 6c09127 to 6f49848 Compare March 12, 2019 11:25

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2019

JustinBeckwith requested a review from callmehiphop March 12, 2019 18:11

callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2019

set sample rate hertz

14e408e

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 13, 2019

update v1p1beta1 spec

4460f22

JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 13, 2019

JustinBeckwith changed the title ~~[CHANGE ME] Re-generated to pick up changes in the API or client library generator.~~ chore: update proto comments and fix tests Mar 13, 2019

JustinBeckwith approved these changes Mar 13, 2019

View reviewed changes

JustinBeckwith merged commit cbc2473 into master Mar 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update proto comments and fix tests #316

chore: update proto comments and fix tests #316

yoshi-automation commented Mar 12, 2019

JustinBeckwith commented Mar 12, 2019

codecov bot commented Mar 13, 2019 •

edited

Loading

googlebot commented Mar 13, 2019

callmehiphop commented Mar 13, 2019 •

edited

Loading

googlebot commented Mar 13, 2019

chore: update proto comments and fix tests #316

chore: update proto comments and fix tests #316

Conversation

yoshi-automation commented Mar 12, 2019

JustinBeckwith commented Mar 12, 2019

codecov bot commented Mar 13, 2019 • edited Loading

Codecov Report

googlebot commented Mar 13, 2019

callmehiphop commented Mar 13, 2019 • edited Loading

googlebot commented Mar 13, 2019

codecov bot commented Mar 13, 2019 •

edited

Loading

callmehiphop commented Mar 13, 2019 •

edited

Loading