Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable noImplicitAny session.ts #697

Merged

Conversation

laljikanjareeya
Copy link
Contributor

@laljikanjareeya laljikanjareeya commented Sep 26, 2019

towards #223

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #697 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #697   +/-   ##
======================================
  Coverage    99.1%   99.1%           
======================================
  Files          12      12           
  Lines        1348    1348           
  Branches      215     215           
======================================
  Hits         1336    1336           
  Misses          4       4           
  Partials        8       8
Impacted Files Coverage Δ
src/session.ts 97.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4571f15...a648d77. Read the comment docs.

@callmehiphop callmehiphop merged commit 1073941 into googleapis:master Sep 27, 2019
@laljikanjareeya laljikanjareeya deleted the session-no-implicit-any branch October 9, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants