Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(codec): improve typescript defs #490

Merged
merged 13 commits into from
Jan 8, 2019
Merged

refactor(codec): improve typescript defs #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e66db51
refactor(codec): improve typescript defs
callmehiphop Dec 28, 2018
33a37bc
tweaks to spanner gapic type defs
callmehiphop Dec 28, 2018
44cef70
integrate codec refactor into other files
callmehiphop Dec 28, 2018
d0549ac
fix borked system tests
callmehiphop Dec 28, 2018
8e96953
fix borked unit tests
callmehiphop Dec 28, 2018
b598dd9
uncomment after hook filter
callmehiphop Dec 28, 2018
342a343
remove only() call
callmehiphop Dec 28, 2018
16ea5b8
run fix
callmehiphop Dec 28, 2018
6c8b413
add wrapStructs option for converting to json
callmehiphop Dec 28, 2018
4349b80
revert to old codec export
callmehiphop Jan 3, 2019
a37db72
unit tests
callmehiphop Jan 3, 2019
e105448
remove unneeded export
callmehiphop Jan 3, 2019
f917648
Merge branch 'master' into dg--codec-types
JustinBeckwith Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/batch-transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ class BatchTransaction extends Transaction {
}
const reqOpts = codec.encodeQuery(query);
const gaxOpts = query.gaxOptions;
if (gaxOpts) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

delete reqOpts.gaxOptions;
}

this.createPartitions_(
{
client: 'SpannerClient',
Expand Down Expand Up @@ -194,9 +192,7 @@ class BatchTransaction extends Transaction {
createReadPartitions(options, callback) {
const reqOpts = codec.encodeRead(options);
const gaxOpts = options.gaxOptions;
if (gaxOpts) {
delete reqOpts.gaxOptions;
}

this.createPartitions_(
{
client: 'SpannerClient',
Expand Down
Loading