Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the sample tests #486

Merged
merged 1 commit into from
Dec 19, 2018
Merged

fix: fix the sample tests #486

merged 1 commit into from
Dec 19, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Dec 19, 2018 •
edited
Loading

I don't entirely understand how these passed previously, but 🤷‍♂️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2018
@JustinBeckwith JustinBeckwith merged commit 2027ddc into googleapis:master Dec 19, 2018
yoshi-automation added a commit that referenced this pull request Apr 17, 2020
@yoshi-automation
build(nodejs): remove unused codecov config (#486)
aa1d188 
Source-Author: Justin Beckwith <[email protected]>
Source-Date: Sat Apr 11 22:08:53 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 21c3b57ae54ae9db6a3a6b48b31c970c6ab56f19
Source-Link: googleapis/synthtool@21c3b57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@jkwlui jkwlui Awaiting requested review from jkwlui

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinBeckwith @crwilcox @googlebot