Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): use unique label for tests #367

Merged
merged 8 commits into from
Oct 16, 2018
Merged

fix(tests): use unique label for tests #367

merged 8 commits into from
Oct 16, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Oct 9, 2018 •
edited
Loading

Fixes #365

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2018
@ghost ghost assigned jkwlui Oct 9, 2018
@stephenplusplus
Copy link
Contributor

We will setup a cron job on Kokoro to periodically clean up instances that are stale.

Should we block this on that? And will the code that does that be here, or something internal?

@ghost ghost assigned JustinBeckwith Oct 12, 2018
@jkwlui
Copy link
Member Author

jkwlui commented Oct 12, 2018

@stephenplusplus @callmehiphop cleanup script ready for your review, thanks! :)

@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2018
stephenplusplus
stephenplusplus reviewed Oct 15, 2018
View reviewed changes
.kokoro/cleanup.sh

npm install

npm run cleanup

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@codecov
Copy link

codecov bot commented Oct 15, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d2f0903). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #367   +/-   ##
=========================================
  Coverage          ?   99.54%           
=========================================
  Files             ?       12           
  Lines             ?     1308           
  Branches          ?        0           
=========================================
  Hits              ?     1302           
  Misses            ?        6           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f0903...2a175c7. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 9596120 into master Oct 16, 2018
@jmdobry jmdobry deleted the system-test-unique-label branch October 16, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

Assignees

@JustinBeckwith JustinBeckwith

@jkwlui jkwlui

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jkwlui @stephenplusplus @callmehiphop @JustinBeckwith @googlebot @kokoro-team