Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable prefer-const in the eslint config #337

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Enable prefer-const in the eslint config #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ rules:
eqeqeq: error
no-warning-comments: warn
no-var: error
prefer-const: error
8 changes: 4 additions & 4 deletions samples/system-test/spanner.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,12 @@ test.serial(`should create query partitions`, async t => {
const [transaction] = await database.createBatchTransaction();
const identifier = JSON.stringify(transaction.identifier());

let results = await tools.runAsyncWithIO(
const results = await tools.runAsyncWithIO(
`${batchCmd} create-query-partitions ${INSTANCE_ID} ${DATABASE_ID} '${identifier}' ${PROJECT_ID}`,
cwd
);

let output = results.stdout + results.stderr;
const output = results.stdout + results.stderr;

t.regex(output, /Successfully created \d query partitions\./);

Expand All @@ -355,12 +355,12 @@ test.serial(`should execute a partition`, async t => {
const [partitions] = await transaction.createQueryPartitions(query);
const partition = JSON.stringify(partitions[0]);

let results = await tools.runAsyncWithIO(
const results = await tools.runAsyncWithIO(
`${batchCmd} execute-partition ${INSTANCE_ID} ${DATABASE_ID} '${identifier}' '${partition}' ${PROJECT_ID}`,
cwd
);

let output = results.stdout + results.stderr;
const output = results.stdout + results.stderr;

t.regex(output, /Successfully received \d from executed partition\./);

Expand Down