Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: callback method in getDatabaseDialect #2078

Merged
merged 1 commit into from
Jul 19, 2024
Merged

chore: callback method in getDatabaseDialect #2078

merged 1 commit into from
Jul 19, 2024

Conversation

alkatrivedi
Copy link
Contributor

@alkatrivedi alkatrivedi commented Jul 9, 2024 •
edited
Loading

fixes: #2075

@alkatrivedi alkatrivedi requested review from a team as code owners July 9, 2024 16:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Jul 9, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
odeke-em
odeke-em reviewed Jul 9, 2024
View reviewed changes
src/database.ts Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2024
odeke-em
odeke-em approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alkatrivedi!

@alkatrivedi
Copy link
Contributor Author

Thanks for approving the PR @odeke-em

@surbhigarg92
Copy link
Contributor

@alkatrivedi Please add a unit test case .

surbhigarg92
surbhigarg92 reviewed Jul 16, 2024
View reviewed changes
src/database.ts Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2024
@alkatrivedi alkatrivedi force-pushed the callback-get-database-dialect branch from 86decda to 547c0bb Compare July 17, 2024 14:33
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@alkatrivedi
Copy link
Contributor Author

@alkatrivedi Please add a unit test case .

A unit test already exists for this

@surbhigarg92 surbhigarg92 merged commit 7e4a8e9 into googleapis:main Jul 19, 2024
16 checks passed
@release-please release-please bot mentioned this pull request Jul 19, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 19, 2024
@release-please
chore(main): release 7.10.0 (#2076)
ce3e646 
🤖 I have created a release *beep* *boop*
---


## [7.10.0](https://togithub.com/googleapis/nodejs-spanner/compare/v7.9.1...v7.10.0) (2024-07-19)


### Features

* Add field lock_hint in spanner.proto ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b))
* Add field order_by in spanner.proto ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b))
* Add QueryCancellationAction message in executor protos ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b))
* Add support for change streams transaction exclusion option for Batch Write ([#2070](https://togithub.com/googleapis/nodejs-spanner/issues/2070)) ([2a9e443](https://togithub.com/googleapis/nodejs-spanner/commit/2a9e44328acda310db2d0d65d32ad82d77a9fcb0))
* **spanner:** Add support for Cloud Spanner Scheduled Backups ([#2045](https://togithub.com/googleapis/nodejs-spanner/issues/2045)) ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b))
* Update Nodejs generator to send API versions in headers for GAPICs ([47520e9](https://togithub.com/googleapis/nodejs-spanner/commit/47520e927b0fdcc60cb67378b8b49f44329f210b))


### Bug Fixes

* Callback in getDatabaseDialect ([#2078](https://togithub.com/googleapis/nodejs-spanner/issues/2078)) ([7e4a8e9](https://togithub.com/googleapis/nodejs-spanner/commit/7e4a8e9ad4f785b15b68aaa06b6480098d7995ba))
* **deps:** Update dependency google-gax to v4.3.8 ([#2077](https://togithub.com/googleapis/nodejs-spanner/issues/2077)) ([e927880](https://togithub.com/googleapis/nodejs-spanner/commit/e927880ff786a2528a2bbb063a244af3c42ff69c))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

@odeke-em odeke-em odeke-em approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database.getDatabaseDialect's "cb" argument is never used
4 participants
@alkatrivedi @surbhigarg92 @odeke-em @yoshi-kokoro