Skip to content

Commit

Permalink
Address code review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
odeke-em committed Oct 1, 2024
1 parent d4f4f1a commit 4ac4080
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
3 changes: 1 addition & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@ export type GetInstanceConfigOperationsCallback = PagedCallback<
* @property {google.spanner.v1.IDirectedReadOptions} [directedReadOptions] Sets the DirectedReadOptions for all ReadRequests and ExecuteSqlRequests for the Client.
* Indicates which replicas or regions should be used for non-transactional reads or queries.
* DirectedReadOptions won't be set for readWrite transactions"
* @property {ObservabilityOptions} [observabilityOptions] defines the configuration
* for OpenTelemetry Tracing.
* @property {ObservabilityOptions} [observabilityOptions] Sets the observability options to be used for OpenTelemetry tracing
*/
export interface SpannerOptions extends GrpcClientOptions {
apiEndpoint?: string;
Expand Down
12 changes: 6 additions & 6 deletions src/instrument.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ interface SQLStatement {
}

/*
* ObservabilityOptions defines the configuration with which
* startTrace may be invoked if set.
* @property [tracerProvider] is the injected TracerProvider to use,
* otherwise the global TracerProvider shall be used.
* @property [enableExtendedTracing] when set signifies that spans started
* with an accompanying an SQL statement shall be annotated with that SQL.
* ObservabilityOptions defines the configuration to be used for Spanner OpenTelemetry Traces.
* @property [tracerProvider] Sets the TracerProvider to be used for traces,
* Global TracerProvider will be used as a fallback.
* @property [enableExtendedTracing] Sets whether to enable extended OpenTelemetry tracing. Enabling this option will add the
* following additional attributes to the traces that are generated by the client
* db.statement: Contains the SQL statement that is being executed.
* Alternatively, you could set environment variable `SPANNER_ENABLE_EXTENDED_TRACING=true`.
*/
interface ObservabilityOptions {
Expand Down

0 comments on commit 4ac4080

Please sign in to comment.