Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency c8 to v7 #838

Merged
merged 3 commits into from
Jan 4, 2020

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Dec 22, 2019

This PR contains the following updates:

Package Type Update Change
c8 devDependencies major ^6.0.1 -> ^7.0.0

Release Notes

bcoe/c8

v7.0.0

Compare Source

⚠ BREAKING CHANGES
  • new test-exclude with modified exclude rules (#​179)
  • istanbul-reports: lcov reports now use relative paths (#​168)
Features
Bug Fixes
6.0.1 (2019-10-26)
Bug Fixes
  • regex flags in dependency were breaking Node 8 (a9d9645)

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 22, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 22, 2019
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #838 into master will decrease coverage by 59.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #838       +/-   ##
===========================================
- Coverage   98.69%   39.41%   -59.29%     
===========================================
  Files          20       32       +12     
  Lines        9443    23645    +14202     
  Branches      326      326               
===========================================
  Hits         9320     9320               
- Misses        122    14324    +14202     
  Partials        1        1
Impacted Files Coverage Δ
src/v1/doc/google/protobuf/doc_empty.js 0% <0%> (ø)
src/v1/doc/google/protobuf/doc_timestamp.js 0% <0%> (ø)
proto/pubsub.d.ts 0% <0%> (ø)
src/v1/doc/google/protobuf/doc_field_mask.js 0% <0%> (ø)
src/v1/doc/google/protobuf/doc_duration.js 0% <0%> (ø)
src/v1/doc/google/type/doc_expr.js 0% <0%> (ø)
src/v1/doc/google/iam/v1/doc_iam_policy.js 0% <0%> (ø)
src/v1/doc/google/iam/v1/doc_policy.js 0% <0%> (ø)
bin/benchwrapper.js 0% <0%> (ø)
src/v1/doc/google/pubsub/v1/doc_pubsub.js 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0107f15...80eb797. Read the comment docs.

@bcoe
Copy link
Contributor

bcoe commented Dec 26, 2019

@callmehiphop @feywind @alexander-fenster I'd like to dig in to why our tests don't seem to exercise a bunch of these files, is it vestigial code we could drop? missing tests? I've noticed a few other libraries have the same uncovered files.

@forking-renovate
Copy link

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@feywind
Copy link
Collaborator

feywind commented Dec 26, 2019

@bcoe I had some related questions in regards to the v1 client in general. Are we planning on deprecating that and removing it eventually, or is it serving another purpose? (In which case, why are we calling it "v1"...)

@bcoe bcoe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2019
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 4, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 4, 2020
@alexander-fenster alexander-fenster merged commit f8f7506 into googleapis:master Jan 4, 2020
@renovate-bot renovate-bot deleted the renovate/c8-7.x branch January 4, 2020 08:36
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/dfbad313-7afb-4cf6-b229-0476fcc2130c/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@57c23fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants