DOC: Fix ackDeadline configuration for subscription #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackDeadline will not affect new subscription https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create
antono
changed the title
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 848 848
=====================================
Hits 848 848
Continue to review full report at Codecov.
|
callmehiphop
approved these changes
Feb 28, 2018
stephenplusplus
pushed a commit
to stephenplusplus/nodejs-pubsub
that referenced
this pull request
Aug 31, 2018
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
…oogleapis#82) * added waitForReplication method to table.js * added code review changes * review update change interval to timeout and add test-cases * added review updates * Methods ordering and CheckConsistencyResponse handler updated * Added timer based test-cases and generateConsistencyToken method to public table.js * Added review change-requests * lint error fixed * typo fix * parameters dcumented * code-review and test-coverage updates * change in test/table.js for check consistency * added ES6-class-syntax, name-vs-id updated, unnecessary this.timeout removed, used responses pattern * updated response for generateConsistencyToken and checkConsistency and added system-test-case * added requested changes * added requested changes * Updating test/table.js with ifError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ackDeadline will not affect new subscription
https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create