test: add missing packages and install test #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Mar 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 16 16
Lines 959 959
Branches 84 84
=======================================
Hits 909 909
Misses 42 42
Partials 8 8Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Mar 8, 2019
| "extends": "./node_modules/gts/tsconfig-google.json", | ||
| "compilerOptions": { | ||
| "rootDir": ".", | ||
| "outDir": "build" |
There was a problem hiding this comment.
Should we try setting types: [ "node" ] here to see what happens? Maybe to repair #526?
There was a problem hiding this comment.
Also, skipLibCheck? #532
There was a problem hiding this comment.
SGTM! Should we consider testing against yarn pnp too?
There was a problem hiding this comment.
Eh, other priorities right now :) If it's easy, go fer it
JustinBeckwith
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #526 (comment)