-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(message): use precise-date for message publish time #503
feat(message): use precise-date for message publish time #503
Conversation
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 94.83% 94.91% +0.08%
==========================================
Files 15 15
Lines 987 984 -3
Branches 83 83
==========================================
- Hits 936 934 -2
+ Misses 43 42 -1
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is this a breaking change?
@JustinBeckwith technically yes, but I don't expect it to impact anyone. (famous last words) |
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
publishTime
is returned with microsecond precision, seems like a great use case for precise date!