Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make smoke test spam less #459

Merged
merged 2 commits into from
Feb 1, 2019
Merged

test: make smoke test spam less #459

merged 2 commits into from
Feb 1, 2019

Conversation

alexander-fenster
Copy link
Contributor

If we had charged tests for using lines of stdout, this one would've gone bankrupt soon.
(I use this in gax system tests and hate it when I need to scroll down tons of lines this test prints)

  • Tests and linter pass (well, I hope so)
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@alexander-fenster
test: make smoke test spam less
ea13672 
If we had charged tests for using lines of stdout, this one would've gone bankrupt soon.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@alexander-fenster alexander-fenster merged commit 3d21473 into master Feb 1, 2019
@alexander-fenster alexander-fenster deleted the no-console-log branch February 1, 2019 15:35
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@renovate @JustinBeckwith
chore(deps): update dependency gts to v1 (googleapis#459)
7a94c1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexander-fenster @crwilcox @callmehiphop @googlebot @kokoro-team