Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): correct publish retry settings #419

Merged
merged 5 commits into from
Jan 14, 2019
Merged

docs(samples): correct publish retry settings #419

merged 5 commits into from
Jan 14, 2019

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Jan 10, 2019

  • corrected retryCodes to a list of Google API canonical error codes
  • corrected backOffSettings to default values specified in src/v1/publisher_client_config.json

ref: https://googleapis.github.io/gax-nodejs/gax.js.html

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2019
@jkwlui
Copy link
Member

jkwlui commented Jan 10, 2019

@stephenplusplus @callmehiphop need a closer look into this one. Had a look at gax-nodejs but I wasn’t familiar enough to determine whether retry parameter is supplied the way it should be.

@callmehiphop
Copy link
Contributor

@kinwa91 If we're just supplying the default retry options for publishing, then these definitely match what is listed in the publisher_client_config.json. I'm concerned that these could become out of sync in the future if the config json is regenerated with tweaked values.

@anguillanneuf
Copy link
Contributor Author

@kinwa91 The sample should be ready to be merged now. Thanks!

@JustinBeckwith JustinBeckwith changed the title Correct publish retry settings docs(samples): correct publish retry settings Jan 14, 2019
@JustinBeckwith JustinBeckwith merged commit 9e793ad into googleapis:master Jan 14, 2019
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants