Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for v0.20.0 from v0.19.0 #398

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Dec 7, 2018

It was reported that when upgrading from v0.19 to v0.20 an error about requiring new was exposed. Adding a note about this change to the changelog

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

It was reported that when upgrading from v0.19 to v0.20 an error about requiring new was exposed. Adding a note about this change to the changelog
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2018
@crwilcox crwilcox requested review from JustinBeckwith and jkwlui and removed request for JustinBeckwith and jkwlui December 7, 2018 20:49
@JustinBeckwith
Copy link
Contributor

Thanks :). Can you add this change to the GitHub release as well?

@crwilcox crwilcox merged commit 407ad5e into master Dec 7, 2018
@stephenplusplus stephenplusplus deleted the crwilcox-patch-1 branch November 26, 2019 12:21
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants