-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ts-ignoring some stuff in tests #343
Conversation
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=========================================
Coverage ? 96.42%
=========================================
Files ? 13
Lines ? 1062
Branches ? 144
=========================================
Hits ? 1024
Misses ? 32
Partials ? 6 Continue to review full report at Codecov.
|
Hi @alexander-fenster I made some changes so we don't have to resort to ts-ignore :) |
Thanks @kinwa91! Can you please make a patch release when this PR lands? |
Note: samples test in Kokoro is flaky :( |
Merged - please use your release magic tool to draft a patch release to make gax system tests work! I have no idea how to do it :) |
These lines in test cause
tsc
errors both locally and in gax system tests. No idea why/how it passes in Pub/Sub CI but anyway, let's@ts-ignore
failing lines for now.