Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ts): introduce a round of types #319

Merged
merged 2 commits into from
Nov 7, 2018
Merged

refactor(ts): introduce a round of types #319

merged 2 commits into from
Nov 7, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2018
@JustinBeckwith JustinBeckwith requested a review from a team November 6, 2018 07:05
@JustinBeckwith
Copy link
Contributor Author

ping @kinwa91

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@f50fd13). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #319   +/-   ##
========================================
  Coverage          ?   96.4%           
========================================
  Files             ?      13           
  Lines             ?    1057           
  Branches          ?     143           
========================================
  Hits              ?    1019           
  Misses            ?      32           
  Partials          ?       6
Impacted Files Coverage Δ
src/snapshot.ts 100% <ø> (ø)
src/publisher.ts 98.03% <ø> (ø)
src/topic.ts 98.66% <ø> (ø)
src/subscription.ts 99.07% <ø> (ø)
src/iam.ts 100% <100%> (ø)
src/index.ts 100% <100%> (ø)
src/histogram.ts 100% <100%> (ø)
src/subscriber.ts 98.7% <100%> (ø)
src/connection-pool.ts 99.43% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50fd13...170118d. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 8c1efa6 into googleapis:master Nov 7, 2018
@JustinBeckwith JustinBeckwith deleted the ts2 branch February 4, 2019 18:07
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants