Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: attempt to make some tests more deterministic #1311

Merged
merged 1 commit into from
Jun 11, 2021
Merged

tests: attempt to make some tests more deterministic #1311

merged 1 commit into from
Jun 11, 2021

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jun 11, 2021

This is an attempt to fix a few non-deterministic things that popped up from the schema sample tests.

@feywind feywind requested review from a team as code owners June 11, 2021 15:26
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jun 11, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2021
@feywind feywind merged commit a211f6a into googleapis:master Jun 11, 2021
@feywind feywind deleted the fix-schema-tests branch June 11, 2021 15:52
This was referenced Jun 11, 2021
Closed
Closed
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@gcf-owl-bot @sofisl
chore!: upgrade to Node 14 (googleapis#1311)
4330cb2 
* docs: fix node release schedule link

Co-authored-by: Jeffrey Rennie <[email protected]>

Source-Link: googleapis/synthtool@1a24315
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430

* chore!: upgrade to Node 14

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Sofia Leon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feywind @bcoe