-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
axios library throws error on createTopic #85
Comments
Hey @jamorales-bsft, thanks for reporting. I've tried this and haven't found it to fail for me. Could you show the minimum necessary code to reproduce? Are you authenticating with a key file or automatically through GKE? Also, it could be a case where there was a temporary failure in a transient module. It might be worth re-deploying or otherwise updating the dependencies to see if something got sorted out on its own. |
@stephenplusplus Unfortunately this only happens when we deploy to k8. When run locally on my Mac and my coworkers Mac everything works fine. Also it only starts happening when using v0.16.x of the pubsub lib. 0.14.8 works fine with the exact same code. I included some code that reproduces it but again this only happens when deployed as a container on GKE. We have not tried minikube or docker directly. We also tried running it on linux locally to see that was breaking it and it worked so really not sure what it could be. Here is the auth line we use Here is the minimum code to reproduce on GKE
|
Also we have redeployed this many times and also npm install from scratch so the dependencies should all be up to date |
Thanks for the extra information. I'll give it another shot. |
I re-deployed using the same code and auth style (a keyfile), but still didn't receive the error. Looking at the stacktrace, it mentions: |
I just tried again this time I:
However it now reproduces locally and on GKE. Here is a gist with a minimum package.json, package-lock.json and npm-list output. I do not know if that will help but maybe you can matchup what libraries you are getting with what I have. |
Thanks for going through all of that. Does |
yea it is of "type": "service_account" |
Could you see if you could get a longer stacktrace that shows where the error comes from within our library? Also, what are the details of your local environment? - OS:
- Node.js version:
- npm version: |
I tried a bunch of things to get a longer stack trace and unfortunately nothing worked. I tried https://github.com/tlrobinson/long-stack-traces which was causing it's own crashes as well as setting the stack-size to 1000. OS: Mac OS 10.13.3 |
@jamorales-bsft since it's been so long, have you still been having this issue? |
Closing this issue due to inactivity. Please reopen if new information comes up. |
Fixes googleapis#85 - [x] Tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) --- This PR should be ready to go. I believe this requires a major semver bump. I figured the test files shouldn't be updated in the same PR. The only thing that really needs to be pointed out is that classes shouldn't be instantiatable without the new keyword: ```js const client1 = new Bigtable() const client2 = Bigtable() // Error: Class constructor Foo cannot be invoked without 'new' ``` I was on the fence about requiring people to use the `new` keyword or not, and chose to make it optional. I did this by using a proxy: ```js Bigtable = new Proxy(Bigtable, { apply(target, thisArg, argumentsList) { return new target(...argumentsList); }, }); ``` Let me know if this should be removed. I didn't add that to the semi-private classes since the common case of creating one is something like `instance.table(...)` and not `new Table(...)` Note - This was removed in review As before, most of this was done via lebab so there may be some issues so please do go through it again to make sure nothing terrible is being done.
Environment details
OS: GKE standard Google container OS
Node.js version: 8.9.1
npm version: 5.6.0
google-cloud-node version: 0.16.4
Steps to reproduce
Note: I ran it locally on my macbook it works however on GKE it fails with the following error when running the exact same code.
Get the following full stack trace
buffer.js:444
throw new TypeError(kConcatErrMsg);
^
TypeError: "list" argument must be an Array of Buffer or Uint8Array instances
at Function.Buffer.concat (buffer.js:444:13)
at IncomingMessage.handleStreamEnd (/var/components/live-meeting-session/node_modules/axios/lib/adapters/http.js:186:37)
at emitNone (events.js:111:20)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1056:12)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
Logs from 3/3/18 4:13 AM to 3/3/18 4:13 AM UTC
The text was updated successfully, but these errors were encountered: