Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API response objects shouldn't use arrays to represent structured data #245

Closed
jganetsk opened this issue Sep 7, 2018 · 2 comments
Closed

API response objects shouldn't use arrays to represent structured data #245

jganetsk opened this issue Sep 7, 2018 · 2 comments
Assignees
@JustinBeckwith
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. release blocking Required feature/issue must be fixed prior to next release. 🚨 This issue needs some love. triage me I really want to be triaged. triaged for GA type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jganetsk
Copy link

jganetsk commented Sep 7, 2018

https://cloud.google.com/nodejs/docs/reference/pubsub/0.19.x/global

Many response types are arrays rather than objects. For example: CreateTopicResponse is an array of size 2 where the first element is a Topic and the second element is "The full API response"

These should be members of an object rather than elements of array.
@theacodes theacodes added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triaged for GA release blocking Required feature/issue must be fixed prior to next release. labels Sep 7, 2018
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Sep 8, 2018
@stephenplusplus
Copy link
Contributor

We have an issue for this, discussing what to do for all of our libraries: googleapis/google-cloud-node#2556

@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Sep 12, 2018
@JustinBeckwith
Copy link
Contributor

👋 We're going to track this up at the master issue for now, and take this on as part of a larger all-up effort across all libraries in Q4.

@ghost ghost removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Sep 13, 2018
@callmehiphop callmehiphop mentioned this issue Jan 15, 2019
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
feywind pushed a commit to feywind/nodejs-pubsub that referenced this issue Nov 12, 2024
@renovate @JustinBeckwith
chore(deps): lock file maintenance (googleapis#245)
40a7480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. release blocking Required feature/issue must be fixed prior to next release. 🚨 This issue needs some love. triage me I really want to be triaged. triaged for GA type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jganetsk @theacodes @JustinBeckwith @stephenplusplus