fix(typescript): correct response type of Subscription.get

src/pubsub.ts

@@ -249,10 +249,10 @@ export class PubSub {
       topic: Topic|string, name: string,
       options?: CreateSubscriptionOptions): Promise<CreateSubscriptionResponse>;
   createSubscription(
-      topic: Topic|string, name: string, options: CreateSubscriptionOptions,
+      topic: Topic|string, name: string,
       callback: CreateSubscriptionCallback): void;
   createSubscription(
-      topic: Topic|string, name: string,
+      topic: Topic|string, name: string, options: CreateSubscriptionOptions,
       callback: CreateSubscriptionCallback): void;
   /**
    * @typedef {array} CreateSubscriptionResponse
@@ -386,10 +386,11 @@ export class PubSub {
         });
   }
 
-  createTopic(name: string, gaxOpts: CallOptions): Promise<CreateTopicResponse>;
-  createTopic(
-      name: string, gaxOpts: CallOptions, callback?: CreateTopicCallback): void;
+  createTopic(name: string, gaxOpts?: CallOptions):
+      Promise<CreateTopicResponse>;
   createTopic(name: string, callback: CreateTopicCallback): void;
+  createTopic(
+      name: string, gaxOpts: CallOptions, callback: CreateTopicCallback): void;
   /**
    * @typedef {array} CreateTopicResponse
    * @property {Topic} 0 The new {@link Topic}.
@@ -484,9 +485,9 @@ export class PubSub {
     this.isEmulator = true;
   }
 
-  getSnapshots(option?: PageOptions): Promise<GetSnapshotsResponse>;
+  getSnapshots(options?: PageOptions): Promise<GetSnapshotsResponse>;
   getSnapshots(callback: GetSnapshotsCallback): void;
-  getSnapshots(option: PageOptions, callback: GetSnapshotsCallback): void;
+  getSnapshots(options: PageOptions, callback: GetSnapshotsCallback): void;
   /**
    * Query object for listing snapshots.
    *

src/subscription.ts

@@ -53,7 +53,7 @@ export type CreateSubscriptionResponse = SubscriptionResponse;
 
 export type GetSubscriptionOptions = CallOptions&{autoCreate?: boolean};
 export type GetSubscriptionCallback = SubscriptionCallback;
-export type GetSubscriptionResponse = SubscriptionCallback;
+export type GetSubscriptionResponse = SubscriptionResponse;
 
 type MetadataCallback = RequestCallback<google.pubsub.v1.ISubscription>;
 type MetadataResponse = [google.pubsub.v1.ISubscription];
@@ -355,9 +355,9 @@ export class Subscription extends EventEmitter {
         });
   }
 
-  createSnapshot(name: string, callback: CreateSnapshotCallback): void;
   createSnapshot(name: string, gaxOpts?: CallOptions):
       Promise<CreateSnapshotResponse>;
+  createSnapshot(name: string, callback: CreateSnapshotCallback): void;
   createSnapshot(
       name: string, gaxOpts: CallOptions,
       callback: CreateSnapshotCallback): void;
@@ -437,8 +437,8 @@ export class Subscription extends EventEmitter {
         });
   }
 
-  delete(callback: EmptyCallback): void;
   delete(gaxOpts?: CallOptions): Promise<EmptyResponse>;
+  delete(callback: EmptyCallback): void;
   delete(gaxOpts: CallOptions, callback: EmptyCallback): void;
   /**
    * Delete the subscription. Pull requests from the current subscription will
@@ -545,8 +545,8 @@ export class Subscription extends EventEmitter {
     });
   }
 
-  get(callback: GetSubscriptionCallback): void;
   get(gaxOpts?: GetSubscriptionOptions): Promise<GetSubscriptionResponse>;
+  get(callback: GetSubscriptionCallback): void;
   get(gaxOpts: GetSubscriptionOptions, callback: GetSubscriptionCallback): void;
   /**
    * @typedef {array} GetSubscriptionResponse

src/topic.ts

@@ -178,7 +178,7 @@ export class Topic {
     callback =
         typeof gaxOptsOrCallback === 'function' ? gaxOptsOrCallback : callback;
 
-    this.pubsub.createTopic(this.name, gaxOpts, callback);
+    this.pubsub.createTopic(this.name, gaxOpts, callback!);
   }
 
   createSubscription(name: string, callback: CreateSubscriptionCallback): void;