Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export types from toplevel #748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

forivall
Copy link

While #411 is marked as closed, it's still bad practice to perform deep imports, and so I'm opening this PR to export the types at the top level.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed) N/A
  • Appropriate docs were updated (if necessary) N/A

Fixes #411 🦕

@forivall forivall requested review from a team as code owners July 22, 2024 19:39
@forivall forivall requested a review from daniel-sanche July 22, 2024 19:39
Copy link

google-cla bot commented Jul 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 22, 2024
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Jul 22, 2024
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Aug 22, 2024
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export types
2 participants