fix: skip parent request entry on cloud run

[wvanderdeijl]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #626

We also suffer from this issue. As a (dirty) workaround we have no added the following code to our own codebase:

// workaround for https://github.com/googleapis/nodejs-logging-bunyan/issues/626 to let lib know we are running in GCP
if (process.env.K_SERVICE && !process.env.GAE_SERVICE) {
    // trick library into thinking we run on AppEngine
    process.env.GAE_SERVICE = process.env.K_SERVICE;
}

[generated-files-bot]

Warning: This pull request is touching the following templated files:

• README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

[losalex]

Thanks @wvanderdeijl for making this change! Overall the change looks good. I wonder if you can also cover this behavior in system-test like one we have in:

nodejs-logging-bunyan/test/middleware/test-express.ts

Line 128 in f3ed3aa

[GCPEnv.APP_ENGINE, GCPEnv.CLOUD_FUNCTIONS].forEach(env => {

[wvanderdeijl]

You mean to test this behaviour in system-test/test-middleware-express.ts?
But that test currently doesn't cover anything about the parent request entry. I could add assertions there for the additional parent request entry but that would make the test dependent on whether you are running in GCP or not as the behaviour of the test would be different. What do you want me to do?

[losalex]

nodejs-logging-bunyan/test/middleware/test-express.ts

I believe we should make sure that for GCPEnv.CLOUD_RUN the behavior is correct when skipParentEntryForCloudRun is set to true

[wvanderdeijl]

@losalex isnt’t that the test I added to nodejs-logging-bunyan/test/middleware/test-express.ts? Or are you looking for something else?

[losalex]

@losalex isnt’t that the test I added to nodejs-logging-bunyan/test/middleware/test-express.ts? Or are you looking for something else?

@wvanderdeijl , my bad, it seems I might confuse you - would you be able to merge your new test with one above? This way we can keep them all together to make sure it will prevent any confusion in the future. Approving the request anyway, up to you if you can make a change to unify the test - good job and thank you!

[losalex]

LGTM

[wvanderdeijl]

@losalex I've integrated into a single test as you requested. But this removed your approval and the work from the bot that updated the README