Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export types #411

Closed
majelbstoat opened this issue Mar 5, 2020 · 1 comment · May be fixed by #748
Closed

Export types #411

majelbstoat opened this issue Mar 5, 2020 · 1 comment · May be fixed by #748
Assignees
@majelbstoat
Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@majelbstoat
Copy link
Contributor

/src/core.d.ts helpfully has Typescript types for things like BunyanLog and HTTPRequest. Unfortunately, even though they're imported into index.d.ts, they're not exported, which means we can't use them for strong typing in userland.

Would you consider exporting types so we don't have to redefine them?
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Mar 5, 2020
@majelbstoat
Copy link
Contributor Author

... and not 10 minutes later I realised I could do this:

import { BunyanLogRecord, HttpRequest } from '@google-cloud/logging-bunyan/build/src/types/core'

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
@forivall forivall mentioned this issue Jul 22, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majelbstoat majelbstoat

Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: export types from toplevel forivall/nodejs-logging-bunyan
2 participants
@majelbstoat @yoshi-automation