Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

chore: update lint rules #69

Merged
merged 2 commits into from
Nov 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google LLC",
"engines": {
"node": ">=4.0.0"
"node": ">=6.0.0"
},
"repository": "googleapis/nodejs-kms",
"main": "src/index.js",
Expand Down Expand Up @@ -35,11 +35,10 @@
"cover": "nyc --reporter=lcov mocha test/*.js && nyc report",
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
"test-no-cover": "mocha test/ --timeout 600000",
"lint": "eslint src/ samples/ system-test/ test/",
"prettier": "prettier --write src/*.js src/*/*.js samples/*.js samples/*/*.js test/*.js test/*/*.js system-test/*.js system-test/*/*.js",
"lint": "eslint '**/*.js'",
"docs": "jsdoc -c .jsdoc.js",
"system-test": "mocha system-test/ smoke-test/ --timeout 600000",
"fix": "eslint '**/*.js' --fix && npm run prettier"
"fix": "eslint '**/*.js' --fix"
},
"dependencies": {
"google-gax": "^0.20.0",
Expand All @@ -58,7 +57,6 @@
"mocha": "^5.2.0",
"nyc": "^13.0.0",
"power-assert": "^1.6.0",
"prettier": "^1.13.7",
"through2": "^3.0.0"
"prettier": "^1.13.7"
}
}
5 changes: 0 additions & 5 deletions samples/system-test/.eslintrc.yml

This file was deleted.

13 changes: 4 additions & 9 deletions synth.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,21 @@
logging.basicConfig(level=logging.DEBUG)

gapic = gcp.GAPICGenerator()
common_templates = gcp.CommonTemplates()

version = 'v1'

library = gapic.node_library(
'kms', version,
config_path='artman_cloudkms.yaml')

# skip index, package.json, and README.md
s.copy(
library,
excludes=['package.json', 'README.md', 'src/index.js'],
)

templates = common_templates.node_library(package_name="@google-cloud/kms")
# Copy common templates
common_templates = gcp.CommonTemplates()
templates = common_templates.node_library()
s.copy(templates)

#
# Node.js specific cleanup
#
subprocess.run(['npm', 'install'])
subprocess.run(['npm', 'run', 'prettier'])
subprocess.run(['npm', 'run', 'lint'])
subprocess.run(['npm', 'run', 'fix'])
1 change: 0 additions & 1 deletion system-test/.eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@
env:
mocha: true
rules:
node/no-unpublished-require: off
no-console: off
2 changes: 0 additions & 2 deletions test/.eslintrc.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
---
env:
mocha: true
rules:
node/no-unpublished-require: off